Skip to content

Remove the deprecated otel/metric/global pkg#3829

Merged
MrAlias merged 6 commits into
open-telemetry:mainfrom
MrAlias:rm-metric-global
Mar 7, 2023
Merged

Remove the deprecated otel/metric/global pkg#3829
MrAlias merged 6 commits into
open-telemetry:mainfrom
MrAlias:rm-metric-global

Conversation

@MrAlias
Copy link
Copy Markdown
Contributor

@MrAlias MrAlias commented Mar 2, 2023

Resolve #3819

@MrAlias MrAlias added this to the v1.15.0 milestone Mar 2, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 2, 2023

Codecov Report

Attention: Patch coverage is 63.88889% with 13 lines in your changes missing coverage. Please review.

Project coverage is 81.7%. Comparing base (3015c86) to head (af4515a).
Report is 1709 commits behind head on main.

Files with missing lines Patch % Lines
internal/global/instruments.go 0.0% 12 Missing ⚠️
internal/global/meter.go 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3829   +/-   ##
=====================================
  Coverage   81.7%   81.7%           
=====================================
  Files        170     168    -2     
  Lines      12474   12462   -12     
=====================================
- Hits       10192   10184    -8     
+ Misses      2067    2063    -4     
  Partials     215     215           
Files with missing lines Coverage Δ
internal/global/state.go 100.0% <100.0%> (ø)
metric.go 66.6% <ø> (ø)
internal/global/meter.go 93.8% <0.0%> (ø)
internal/global/instruments.go 60.8% <0.0%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrAlias MrAlias marked this pull request as ready for review March 2, 2023 19:31
@MrAlias MrAlias merged commit 60f7d42 into open-telemetry:main Mar 7, 2023
@MrAlias MrAlias deleted the rm-metric-global branch March 7, 2023 16:36
@MrAlias MrAlias modified the milestones: v1.15.0, v1.15.0-RC2 Mar 22, 2023
MrAlias added a commit to MrAlias/opentelemetry-go that referenced this pull request Apr 11, 2023
MrAlias added a commit that referenced this pull request Apr 13, 2023
)

* Revert "Remove the deprecated `otel/metric/global` pkg (#3829)"

This reverts commit 60f7d42.

* Revert "Support a global MeterProvider in `go.opentelemetry.io/otel` (#3818)"

This reverts commit 8139361.

* Remove top level metric global

* Add change to changelog
@MrAlias MrAlias added the area:metrics Part of OpenTelemetry Metrics label Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:metrics Part of OpenTelemetry Metrics

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Remove the deprecated otel/metric/global package

4 participants