Document f in RegisterCallback needs to be concurrent safe#4251
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4251 +/- ##
=======================================
- Coverage 83.5% 83.5% -0.1%
=======================================
Files 181 181
Lines 14162 14162
=======================================
- Hits 11832 11830 -2
- Misses 2103 2105 +2
Partials 227 227 🚀 New features to boost your workflow:
|
dmathieu
approved these changes
Jun 23, 2023
hanyuancheung
approved these changes
Jun 25, 2023
MrAlias
reviewed
Jun 27, 2023
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
MrAlias
approved these changes
Jun 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the concurrent safety requirement harder to miss.
See:
opentelemetry-go/metric/meter.go
Lines 174 to 175 in 6b262b4