Skip to content

Document f in RegisterCallback needs to be concurrent safe#4251

Merged
MrAlias merged 4 commits into
open-telemetry:mainfrom
pellared:reader-threadsafe
Jun 27, 2023
Merged

Document f in RegisterCallback needs to be concurrent safe#4251
MrAlias merged 4 commits into
open-telemetry:mainfrom
pellared:reader-threadsafe

Conversation

@pellared
Copy link
Copy Markdown
Member

@pellared pellared commented Jun 23, 2023

Make the concurrent safety requirement harder to miss.

See:

// The function needs to be concurrent safe.
type Callback func(context.Context, Observer) error

@pellared pellared added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 23, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.5%. Comparing base (5e69812) to head (911420a).
Report is 1576 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4251     +/-   ##
=======================================
- Coverage   83.5%   83.5%   -0.1%     
=======================================
  Files        181     181             
  Lines      14162   14162             
=======================================
- Hits       11832   11830      -2     
- Misses      2103    2105      +2     
  Partials     227     227             

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread metric/meter.go Outdated
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@pellared pellared requested a review from MrAlias June 27, 2023 21:18
@MrAlias MrAlias merged commit 8e25817 into open-telemetry:main Jun 27, 2023
@pellared pellared deleted the reader-threadsafe branch June 27, 2023 21:30
@MrAlias MrAlias added the area:metrics Part of OpenTelemetry Metrics label Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:metrics Part of OpenTelemetry Metrics Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

4 participants