Replace filter aggregator with direct filter on measure#4342
Merged
Conversation
MrAlias
added
pkg:SDK
MrAlias
requested review from
Aneurysm9,
MadVikingGod,
XSAM,
dashpole,
dmathieu,
evantorrie,
hanyuancheung and
pellared
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4342 +/- ##
=======================================
- Coverage 83.4% 83.4% -0.1%
=======================================
Files 185 184 -1
Lines 14359 14349 -10
=======================================
- Hits 11985 11975 -10
Misses 2147 2147
Partials 227 227
|
Part of open-telemetry#4220 Instead of using an aggregator to filter measured attributes, directly filter the attributes in the constructed Measure function the Builder creates. Include unit and integration testing of new filtering.
dashpole
approved these changes
Jul 20, 2023
Co-authored-by: David Ashpole <dashpole@google.com>
pellared
approved these changes
Jul 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4220
Instead of using an aggregator to filter measured attributes, directly filter the attributes in the constructed Measure function the Builder creates.
Includes unit testing of new filtering.