Skip to content

Filter metric time series attributes instead of measurements#4816

Closed
MrAlias wants to merge 11 commits into
open-telemetry:mainfrom
MrAlias:filter-on-collect
Closed

Filter metric time series attributes instead of measurements#4816
MrAlias wants to merge 11 commits into
open-telemetry:mainfrom
MrAlias:filter-on-collect

Conversation

@MrAlias
Copy link
Copy Markdown
Contributor

@MrAlias MrAlias commented Jan 8, 2024

@MrAlias MrAlias added the area:metrics Part of OpenTelemetry Metrics label Jan 8, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 8, 2024

Codecov Report

Attention: 81 lines in your changes are missing coverage. Please review.

Comparison is base (6ead8d8) 82.3% compared to head (f2ba1a3) 82.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4816     +/-   ##
=======================================
- Coverage   82.3%   82.0%   -0.3%     
=======================================
  Files        226     226             
  Lines      18392   18556    +164     
=======================================
+ Hits       15148   15234     +86     
- Misses      2963    3036     +73     
- Partials     281     286      +5     
Files Coverage Δ
sdk/metric/internal/aggregate/aggregate.go 100.0% <100.0%> (ø)
sdk/metric/internal/aggregate/lastvalue.go 100.0% <100.0%> (ø)
sdk/metric/internal/aggregate/sum.go 100.0% <100.0%> (ø)
sdk/metric/internal/aggregate/histogram.go 98.3% <91.6%> (-1.7%) ⬇️
...metric/internal/aggregate/exponential_histogram.go 76.9% <35.0%> (-19.3%) ⬇️

... and 1 file with indirect coverage changes

@MrAlias MrAlias added the blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made label Jan 8, 2024
@MrAlias
Copy link
Copy Markdown
Contributor Author

MrAlias commented Jan 29, 2024

Closing. There is not a consensus to resolve open-telemetry/opentelemetry-specification#3803 and there is no strong community desire that I can see to want to support this yet.

@MrAlias MrAlias closed this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:metrics Part of OpenTelemetry Metrics blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate if attribute filtering should be in the instrument or aggregator

1 participant