Skip to content

Add the Drop exemplar Reservoir implementation#4850

Merged
MrAlias merged 2 commits into
open-telemetry:mainfrom
MrAlias:add-drop-exemplar-res
Jan 25, 2024
Merged

Add the Drop exemplar Reservoir implementation#4850
MrAlias merged 2 commits into
open-telemetry:mainfrom
MrAlias:add-drop-exemplar-res

Conversation

@MrAlias
Copy link
Copy Markdown
Contributor

@MrAlias MrAlias commented Jan 24, 2024

Part of #559

This PR is split from #4455

@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 24, 2024
@MrAlias MrAlias added this to the v1.23.0 milestone Jan 24, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6f96e67) 82.3% compared to head (fe8261a) 82.3%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4850     +/-   ##
=======================================
- Coverage   82.3%   82.3%   -0.1%     
=======================================
  Files        226     227      +1     
  Lines      18557   18563      +6     
=======================================
+ Hits       15288   15292      +4     
- Misses      2981    2983      +2     
  Partials     288     288             
Files Coverage Δ
sdk/metric/internal/exemplar/drop.go 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

@MrAlias MrAlias force-pushed the add-drop-exemplar-res branch from 4dc4067 to fe8261a Compare January 25, 2024 20:08
@MrAlias MrAlias merged commit 08beb8b into open-telemetry:main Jan 25, 2024
@MrAlias MrAlias deleted the add-drop-exemplar-res branch January 25, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants