Skip to content

Add the SampledFilter exemplar Reservoir implementation#4851

Merged
MrAlias merged 3 commits into
open-telemetry:mainfrom
MrAlias:add-exemplar-fltr
Jan 25, 2024
Merged

Add the SampledFilter exemplar Reservoir implementation#4851
MrAlias merged 3 commits into
open-telemetry:mainfrom
MrAlias:add-exemplar-fltr

Conversation

@MrAlias
Copy link
Copy Markdown
Contributor

@MrAlias MrAlias commented Jan 24, 2024

This Reservoir implementation is used at the MeterProvider level to pre-filter measurements offered to a wrapped Reservoir.

Part of #559

This PR is split from #4455

This Reservoir implementaiton is used at the MeterProvider level to
pre-filter measurements offered to a wrapped Reservoir.
@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 24, 2024
@MrAlias MrAlias added this to the v1.23.0 milestone Jan 24, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (08beb8b) 82.3% compared to head (79ffca9) 82.3%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4851   +/-   ##
=====================================
  Coverage   82.3%   82.3%           
=====================================
  Files        227     228    +1     
  Lines      18563   18569    +6     
=====================================
+ Hits       15292   15300    +8     
+ Misses      2983    2981    -2     
  Partials     288     288           
Files Coverage Δ
sdk/metric/internal/exemplar/filter.go 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

@MrAlias MrAlias merged commit 79371c1 into open-telemetry:main Jan 25, 2024
@MrAlias MrAlias deleted the add-exemplar-fltr branch January 25, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants