Skip to content

Add the Histogram Reservoir implementations#4870

Merged
MrAlias merged 2 commits into
open-telemetry:mainfrom
MrAlias:add-hist-res
Jan 30, 2024
Merged

Add the Histogram Reservoir implementations#4870
MrAlias merged 2 commits into
open-telemetry:mainfrom
MrAlias:add-hist-res

Conversation

@MrAlias
Copy link
Copy Markdown
Contributor

@MrAlias MrAlias commented Jan 29, 2024

Part of #559

This PR is split from #4455

This adds a Reservoir implementation for histograms as described by the specification:

This implementation MUST keep the last seen measurement that falls within a histogram bucket.

@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 29, 2024
@MrAlias MrAlias added this to the v1.23.0 milestone Jan 29, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e6e4c95) 82.5% compared to head (c0233af) 82.5%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4870   +/-   ##
=====================================
  Coverage   82.5%   82.5%           
=====================================
  Files        230     231    +1     
  Lines      18754   18762    +8     
=====================================
+ Hits       15480   15488    +8     
  Misses      2985    2985           
  Partials     289     289           
Files Coverage Δ
sdk/metric/internal/exemplar/hist.go 100.0% <100.0%> (ø)

@MrAlias MrAlias merged commit e7de571 into open-telemetry:main Jan 30, 2024
@MrAlias MrAlias deleted the add-hist-res branch January 30, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants