Add the experimental exemplar feature#4871
Merged
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4871 +/- ##
=======================================
+ Coverage 82.5% 82.6% +0.1%
=======================================
Files 231 232 +1
Lines 18762 18872 +110
=======================================
+ Hits 15488 15600 +112
+ Misses 2985 2982 -3
- Partials 289 290 +1
|
dashpole
reviewed
Jan 30, 2024
dashpole
reviewed
Jan 30, 2024
Collaborator
dashpole
left a comment
There was a problem hiding this comment.
implementation looks good, but it looks like it needs unit tests?
Contributor
Author
Right. Added c589d01 PTAL |
c589d01 to
22b463d
Compare
This only has a single use.
pellared
reviewed
Jan 31, 2024
dashpole
reviewed
Jan 31, 2024
Default and invalid OTEL_METRICS_EXEMPLAR_FILTER. Test sampled and non-sampled context for trace_based.
dashpole
approved these changes
Jan 31, 2024
pellared
approved these changes
Jan 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate the exemplar package into the metric SDK as an experimental feature.
Closes #4455
Resolves #559
Benchmark