sdk/trace: trace id high 64 bit tests #7212
Open
+22
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahendrabishnoi2
requested review from
MrAlias,
XSAM,
dashpole,
pellared,
dmathieu and
flc1125
as code owners
|
Reviewers, please add skip changelog label. |
6 tasks
|
This PR is ready for review. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7212 +/- ##
=======================================
- Coverage 85.5% 85.5% -0.1%
=======================================
Files 277 277
Lines 24654 24654
=======================================
- Hits 21088 21086 -2
- Misses 3187 3189 +2
Partials 379 379 🚀 New features to boost your workflow:
|
MrAlias
approved these changes
Sep 30, 2025
pellared
approved these changes
Oct 1, 2025
pellared
reviewed
Oct 1, 2025
Comment on lines
+1934
to
+1935
| high uint64 | ||
| low uint64 |
There was a problem hiding this comment.
Suggested change
| high uint64 | |
| low uint64 | |
| traceIDHigh uint64 | |
| traceIDLow uint64 |
Comment on lines
+1959
to
+1960
| startHigh uint64 = 0x1001_1001_1001_1001 | ||
| startLow uint64 = 0x2002_2002_2002_2002 |
There was a problem hiding this comment.
Suggested change
| startHigh uint64 = 0x1001_1001_1001_1001 | |
| startLow uint64 = 0x2002_2002_2002_2002 | |
| startTraceIDHigh uint64 = 0x1001_1001_1001_1001 | |
| startTraceIDLow uint64 = 0x2002_2002_2002_2002 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7160
testIDGeneratorto have both low and high bits (in uint64 form) since we can't store 128 bits integerDoes not need a CHANGELOG entry - test only.