feat(opentelemetry-collector): use Kubernetes recommended label for c… #1396
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omponent Signed-off-by: Nicolas Lamirault <[email protected]>
nlamirault
requested review from
dmitryax,
TylerHelmuth,
povilasv and
a team
as code owners
|
I guess this is breaking change 🤔 People could have used component=agent-collector in other resources like Ingress / Network policies / ... So maybe we should stick with old label? |
|
I agree this is a breaking change. We can add a new label but should leave the existing one for now. |
Signed-off-by: Nicolas Lamirault <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Kubernetes commended labels for
componentlabel.