Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to split the image registry and the repository #1400

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Allow to split the image registry and the repository #1400

wants to merge 5 commits into from

Conversation

aacevedoosorio
Copy link
Contributor

The current helm chart allows to set a global.imageRegistry in combination with the repository configured. But it would be nice as well to split the repository into the default registry for charts that use the open-telemetry chart as a subchart and have a default predefined repository.

TylerHelmuth
TylerHelmuth reviewed Oct 29, 2024
View reviewed changes
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run make generate-examples CHARTS=opentelemetry-collector

TylerHelmuth
TylerHelmuth reviewed Oct 29, 2024
View reviewed changes
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need a new example, but can you share the output of the image string being set properly when using the new field and the global field?

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Oct 30, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@aacevedoosorio aacevedoosorio force-pushed the opentelemetry-collector-imageRegistry_imagePullSecrets branch 4 times, most recently from 0d1363b to 2b47c03 Compare October 30, 2024 13:01
@aacevedoosorio
Copy link
Contributor Author

We don't need a new example, but can you share the output of the image string being set properly when using the new field and the global field?

I ended up creating the examples. I think they are valuable

@aacevedoosorio aacevedoosorio force-pushed the opentelemetry-collector-imageRegistry_imagePullSecrets branch from 2b47c03 to e56b1a9 Compare October 30, 2024 13:09
@aacevedoosorio aacevedoosorio force-pushed the opentelemetry-collector-imageRegistry_imagePullSecrets branch from e56b1a9 to 40097ca Compare October 30, 2024 13:13
TylerHelmuth
TylerHelmuth reviewed Oct 30, 2024
View reviewed changes
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aacevedoosorio the new examples give me confidence that this process works, but I don't want to merge this PR with them. Using these options in the values.yaml is straight forward for an end-user even if the logic to build the string is kinda complex.

@aacevedoosorio
Copy link
Contributor Author

@aacevedoosorio the new examples give me confidence that this process works, but I don't want to merge this PR with them. Using these options in the values.yaml is straight forward for an end-user even if the logic to build the string is kinda complex.

I get your point. Let me revert those examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@povilasv povilasv Awaiting requested review from povilasv povilasv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aacevedoosorio @TylerHelmuth