add Nullaway to instrumentation API #14458
Conversation
github-actions
bot
added
the
test native
|
🔧 The result from spotlessApply was committed to the PR branch. |
1 similar comment
|
🔧 The result from spotlessApply was committed to the PR branch. |
...o/opentelemetry/javaagent/instrumentation/activejhttp/ActivejHttpServerAttributesGetter.java
Outdated
Show resolved
Hide resolved
zeitlinger
force-pushed
the
nullaway-inst-api
branch
from
4d1d120 to
dca4806
Compare
| private static final Instrumenter<Void, Void> INSTRUMENTER = | ||
| Instrumenter.<Void, Void>builder( | ||
| private static final Object REQUEST = new Object(); | ||
|
|
||
| private static final Instrumenter<Object, Void> INSTRUMENTER = | ||
| Instrumenter.<Object, Void>builder( |
There was a problem hiding this comment.
it passed null as request param - which is not nullable
| @Nullable String method, | ||
| @Nullable String route, | ||
| int updatedBySourceOrder, | ||
| @Nullable Span span) { |
There was a problem hiding this comment.
just checking, is null Span ever passed in here?
There was a problem hiding this comment.
just above: create(method, route, updatedBySourceOrder, null);
| @@ -19,6 +19,7 @@ | |||
| * This class is internal and is hence not for public use. Its APIs are unstable and can change at | |||
| * any time. | |||
| */ | |||
| @SuppressWarnings("NullAway") // setters called in static initializer | |||
There was a problem hiding this comment.
I don't see static initializer in this class? or is it called from another class?
There was a problem hiding this comment.
It's the static methods setInstrumenterAccess and setInstrumenterBuilderAccess
I realized that we could also add an @Initializer annotation to those methods - but we'd need a place to add this annotation.
See https://github.com/uber/NullAway/wiki/Supported-Annotations#initialization
There was a problem hiding this comment.
oh, maybe it wants the static fields to be annotated with @Nullable
There was a problem hiding this comment.
if we'd do that - we'd get an error when the field is accessed: instrumenterAccess.startAndEnd
There was a problem hiding this comment.
I just added the annotation to see if that looks better
|
@trask can you check again? |
No description provided.