move Declarative config bridge to a dedicated module #14548
+38
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@laurit please have a look |
jaydeluca
reviewed
Aug 29, 2025
Co-authored-by: Jay DeLuca <[email protected]>
trask
reviewed
Aug 29, 2025
trask
reviewed
Aug 29, 2025
...e-config-bridge/src/main/java/io/opentelemetry/instrumentation/sdk/ConfigPropertiesUtil.java
Outdated
Show resolved
Hide resolved
|
@laurit please take a look 😄 |
jaydeluca
approved these changes
Sep 4, 2025
trask
reviewed
Sep 4, 2025
javaagent-tooling/build.gradle.kts
Outdated
Comment on lines
20
to
24
| implementation(project(":declarative-config-bridge")) { | ||
| // is part of bootstrap classpath | ||
| exclude(group = "io.opentelemetry", module = "opentelemetry-api-incubator") | ||
| exclude(group = "io.opentelemetry", module = "opentelemetry-sdk-extension-autoconfigure-spi") | ||
| } |
There was a problem hiding this comment.
do we need these exclusions? e.g. instrumentation-api-incubator above doesn't have the exclusion for opentelemetry-api-incubator
| @@ -57,6 +57,7 @@ dependencies { | |||
| bootstrapLibs(project(":instrumentation-api")) | |||
| // opentelemetry-api is an api dependency of :instrumentation-api, but opentelemetry-api-incubator is not | |||
| bootstrapLibs("io.opentelemetry:opentelemetry-api-incubator") | |||
| bootstrapLibs(project(":instrumentation-api-incubator")) | |||
There was a problem hiding this comment.
can we remove this now that we've moved it over to declarative-config-bridge?
There was a problem hiding this comment.
this just restores the way things were before the bridge was added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.