make xxl-job indy-ready #14571
Merged
make xxl-job indy-ready #14571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasKunz
approved these changes
Sep 3, 2025
laurit
reviewed
Sep 4, 2025
| @Advice.Local("otelContext") Context context, | ||
| @Advice.Local("otelScope") Scope scope) { | ||
| helper().stopSpan(result, request, throwable, scope, context); | ||
| @Advice.Return(typing = Assigner.Typing.DYNAMIC) @Nullable Object result, |
There was a problem hiding this comment.
wondering whether Assigner.Typing.DYNAMIC is really needed when assigning to Object
There was a problem hiding this comment.
I wonder the same, I left it as-is for simplicity but it should be safe to remove it in the future.
laurit
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #13031 for xxl-job instrumentation
bonus: reducing duplicated advice code.