Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate rxjava3 unit tests to Java #7924

Merged
merged 5 commits into from
Apr 21, 2023
Merged

Migrate rxjava3 unit tests to Java #7924

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e84d780
init rxjava3 junit test
kaibocai7 Feb 20, 2023
da171e6
fix test
kaibocai7 Apr 2, 2023
c806de8
fix cancel test cases
kaibocai7 Apr 11, 2023
c42e1d1
fix tests in RxJava3AsyncOperationEndStrategyTest
kaibocai7 Apr 12, 2023
d524f7a
fix tests name
kaibocai7 Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions ...sting/src/main/java/io/opentelemetry/instrumentation/reactor/AbstractReactorCoreTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;

import com.google.common.primitives.Ints;
import io.opentelemetry.api.trace.Span;
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
import io.opentelemetry.sdk.testing.assertj.TraceAssert;
Expand Down Expand Up @@ -116,22 +115,6 @@ void basicFlux() {
span -> span.hasName("add one").hasParent(trace.getSpan(0))));
}

@Test
void basicFluxIterable() {
List<Integer> result =
testing.runWithSpan(
"parent",
() -> Flux.fromIterable(Ints.asList(5, 6)).map(this::addOne).collectList().block());
assertThat(result).containsExactly(6, 7);

testing.waitAndAssertTraces(
trace ->
trace.hasSpansSatisfyingExactly(
span -> span.hasName("parent").hasNoParent(),
span -> span.hasName("add one").hasParent(trace.getSpan(0)),
span -> span.hasName("add one").hasParent(trace.getSpan(0))));
}

@Test
void twoOperationsFlux() {
List<Integer> result =
Expand Down
Loading