Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update Windows-specific guidance for running Prometheus exporter test #6823

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Annosha
Copy link

@Annosha Annosha commented Oct 26, 2024

Referencing the issue noted here JApiCmp Failure in setting up opentelemetry-java locally, it would be beneficial for beginner contributors to include guidance on handling Prometheus test failures on Windows, along with an alternative command. This addition will help new contributors navigate the setup process more smoothly and contribute effectively to the repository.
@trask @shalk

@Annosha Annosha requested a review from a team as a code owner October 26, 2024 14:08
Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.49%. Comparing base (b1cd30e) to head (0c77be6).
Report is 20 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6823      +/-   ##
============================================
+ Coverage     90.12%   90.49%   +0.37%     
- Complexity     6546     6599      +53     
============================================
  Files           728      731       +3     
  Lines         19702    19735      +33     
  Branches       1935     1935              
============================================
+ Hits          17756    17859     +103     
+ Misses         1347     1285      -62     
+ Partials        599      591       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trask
Copy link
Member

trask commented Oct 26, 2024

hi @Annosha! I'm giving it a try to instead fix the tests on Windows (and keep them fixed by running them in CI), see #6824

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants