-
Notifications
You must be signed in to change notification settings - Fork 904
don't call old plugin when declarative config is in use #7472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
don't call old plugin when declarative config is in use #7472
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7472 +/- ##
=========================================
Coverage 89.99% 89.99%
- Complexity 7079 7086 +7
=========================================
Files 803 803
Lines 21412 21434 +22
Branches 2086 2090 +4
=========================================
+ Hits 19269 19290 +21
+ Misses 1479 1478 -1
- Partials 664 666 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@jack-berg please have a look 😄 |
...src/testIncubating/java/io/opentelemetry/sdk/autoconfigure/DeclarativeConfigurationTest.java
Outdated
Show resolved
Hide resolved
1fcf3a4
to
23e1c14
Compare
@jkwatson please have a look |
This seems ok to me, but I don't have the background on the issue, and it seemed like Jack had some hesitation on the original issue. I don't see that resolved in that discussion. Was there a resolution that wasn't communicated in the discussion there? |
you're right - I missed that. I'll have to think about it again. |
23e1c14
to
5b81ef8
Compare
@jkwatson now I added a new interface to address the distro use case |
Fixes #7469
Adds a dedicated SPI to load a declarative config for a distro:
The added test illustrates how to use the SPI: