Better fix for security manager test on Java 24 #7699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
reviewed
Sep 23, 2025
| SunMiscProhibitedSecurityManager sm = new SunMiscProhibitedSecurityManager(); | ||
| assertThatThrownBy(() -> sm.checkPackageAccess("sun.misc")) | ||
| .isInstanceOf(SecurityException.class); | ||
| .isInstanceOf(AccessControlException.class) |
There was a problem hiding this comment.
The javadoc for AccessControlException class say it was deprecated since 17 and is marked for removal, so we'll have to revisit eventually.
For other reviewers -- The AccessControlException is a more specific type of SecurityException.
There was a problem hiding this comment.
ya, this PR effectively rolls back the change I made in #7679
and is more explicit about when and why it fails
breedx-splk
reviewed
Sep 23, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7699 +/- ##
=========================================
Coverage 90.12% 90.12%
Complexity 7187 7187
=========================================
Files 814 814
Lines 21700 21700
Branches 2123 2123
=========================================
Hits 19557 19557
Misses 1477 1477
Partials 666 666 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jack-berg
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #7679