Skip to content

Spec update: Changes to disabled config must be eventually visible #7706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Spec update: Changes to disabled config must be eventually visible #7706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
575c38d
Volatile
trask Sep 25, 2025
b186468
Initial plan
Copilot Sep 29, 2025
dc75cc9
Make enabled fields volatile in SdkTracer, SdkMeter, and MetricStorag…
Copilot Sep 29, 2025
fe84c31
Merge pull request #95 from trask/copilot/fix-de9e7177-fc58-493c-adde…
trask Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions sdk/logs/src/main/java/io/opentelemetry/sdk/logs/SdkLogger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,7 @@ class SdkLogger implements Logger {
private final LoggerSharedState loggerSharedState;
private final InstrumentationScopeInfo instrumentationScopeInfo;

// deliberately not volatile because of performance concerns
// - which means its eventually consistent
protected boolean loggerEnabled;
protected volatile boolean loggerEnabled;

SdkLogger(
LoggerSharedState loggerSharedState,
Expand Down
2 changes: 1 addition & 1 deletion sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/SdkMeter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ final class SdkMeter implements Meter {
private final InstrumentationScopeInfo instrumentationScopeInfo;
private final Map<RegisteredReader, MetricStorageRegistry> readerStorageRegistries;

private boolean meterEnabled;
private volatile boolean meterEnabled;

SdkMeter(
MeterProviderSharedState meterProviderSharedState,
Expand Down
2 changes: 1 addition & 1 deletion .../src/main/java/io/opentelemetry/sdk/metrics/internal/state/AsynchronousMetricStorage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public final class AsynchronousMetricStorage<T extends PointData, U extends Exem
private long startEpochNanos;
private long epochNanos;

private boolean enabled;
private volatile boolean enabled;

private AsynchronousMetricStorage(
RegisteredReader registeredReader,
Expand Down
2 changes: 1 addition & 1 deletion ...ain/java/io/opentelemetry/sdk/metrics/internal/state/DefaultSynchronousMetricStorage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public final class DefaultSynchronousMetricStorage<T extends PointData, U extend
private final ConcurrentLinkedQueue<AggregatorHandle<T, U>> aggregatorHandlePool =
new ConcurrentLinkedQueue<>();

private boolean enabled;
private volatile boolean enabled;

DefaultSynchronousMetricStorage(
RegisteredReader registeredReader,
Expand Down
5 changes: 2 additions & 3 deletions sdk/trace/src/main/java/io/opentelemetry/sdk/trace/SdkTracer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,8 @@ class SdkTracer implements Tracer {

private final TracerSharedState sharedState;
private final InstrumentationScopeInfo instrumentationScopeInfo;
// deliberately not volatile because of performance concerns
// - which means its eventually consistent
protected boolean tracerEnabled;

protected volatile boolean tracerEnabled;

SdkTracer(
TracerSharedState sharedState,
Expand Down
Loading