-
Couldn't load subscription status.
- Fork 913
Stabilize ExemplarFilter #7768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Stabilize ExemplarFilter #7768
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7768 +/- ##
============================================
- Coverage 90.18% 90.17% -0.01%
- Complexity 7200 7203 +3
============================================
Files 815 816 +1
Lines 21738 21737 -1
Branches 2130 2130
============================================
- Hits 19604 19602 -2
- Misses 1466 1467 +1
Partials 668 668 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3debba9 to
906dd38
Compare
…y-java into stabilize-exemplar-filter
906dd38 to
d5e2988
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for picking this back up -- I clearly didn't have the cycles to come back to this. 😮💨
| * | ||
| * @see SdkMeterProviderBuilder#setExemplarFilter(ExemplarFilter) | ||
| */ | ||
| // TODO(jack-berg): Have methods when custom filters are supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, yeah without this TODO it sure looks like a weird interface. 👍🏻
Narrower version of #7636.
Resolves #7503.
Notably: