Skip to content

Conversation

@jack-berg
Copy link
Member

Narrower version of #7636.

Resolves #7503.

Notably:

  • Leaves out exemplar reservoir (i.e. DoubleExemplarReservoir, LongExemplarReservoir). There is no internal or public API to configure reservoirs at the moment. There is no point in stabilizing this until we make it configurable.
  • Omits methods on ExemplarFilter since ExemplarFilter is not a SDK extension plugin interface according to the spec

@codecov
Copy link

codecov bot commented Oct 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.17%. Comparing base (6c780f1) to head (d5e2988).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7768      +/-   ##
============================================
- Coverage     90.18%   90.17%   -0.01%     
- Complexity     7200     7203       +3     
============================================
  Files           815      816       +1     
  Lines         21738    21737       -1     
  Branches       2130     2130              
============================================
- Hits          19604    19602       -2     
- Misses         1466     1467       +1     
  Partials        668      668              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jack-berg jack-berg force-pushed the stabilize-exemplar-filter branch 2 times, most recently from 3debba9 to 906dd38 Compare October 28, 2025 20:06
@jack-berg jack-berg force-pushed the stabilize-exemplar-filter branch from 906dd38 to d5e2988 Compare October 28, 2025 20:19
Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for picking this back up -- I clearly didn't have the cycles to come back to this. 😮‍💨

*
* @see SdkMeterProviderBuilder#setExemplarFilter(ExemplarFilter)
*/
// TODO(jack-berg): Have methods when custom filters are supported.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, yeah without this TODO it sure looks like a weird interface. 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stable ExemplarFilter in SdkMeterProviderBuilder

2 participants