fix(deps): update errorproneversion to v2.43.0 #7779
Conversation
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
trask
force-pushed
the
renovate/errorproneversion
branch
3 times, most recently
from
4e04cd2 to
c8a7f8a
Compare
trask
force-pushed
the
renovate/errorproneversion
branch
from
c8a7f8a to
9461819
Compare
|
|
||
| /** Unit tests for No-op {@link Meter}. */ | ||
| @SuppressLogger | ||
| @SuppressWarnings("this-escape") |
There was a problem hiding this comment.
it's not ignored because it's in src/main
| // Need to suppress warnings for MustBeClosed because Android 14 does not support | ||
| // try-with-resources. | ||
| @SuppressWarnings("MustBeClosedChecker") | ||
| @SuppressWarnings({"MustBeClosedChecker", "this-escape"}) |
There was a problem hiding this comment.
another good option is to just ignore this new rule
| protected AggregatorHandle(ExemplarReservoirFactory reservoirFactory) { | ||
| this.isDoubleType = isDoubleType(); | ||
| protected AggregatorHandle(ExemplarReservoirFactory reservoirFactory, boolean isDoubleType) { | ||
| this.isDoubleType = isDoubleType; |
There was a problem hiding this comment.
just an option, if we care about "this" escaping (and seems a bit more direct)
| private static final long serialVersionUID = -6787390183017184775L; | ||
|
|
||
| @Nullable private final HttpSender.Response response; | ||
| @Nullable private final transient HttpSender.Response response; |
There was a problem hiding this comment.
alternatively could make HttpSender.Response serializable...
|
I think probably better to send separate PRs first:
and then come back here |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7779 +/- ##
============================================
- Coverage 90.17% 90.16% -0.01%
Complexity 7189 7189
============================================
Files 814 814
Lines 21730 21724 -6
Branches 2129 2129
============================================
- Hits 19594 19587 -7
- Misses 1467 1469 +2
+ Partials 669 668 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 participant
This PR contains the following updates:
2.42.0->2.43.02.42.0->2.43.02.42.0->2.43.0Release Notes
google/error-prone (com.google.errorprone:error_prone_test_helpers)
v2.43.0: Error Prone 2.43.0Changes:
-XepPatchChecksnow skips disabled checks (#4943)AndroidJdkLibsCheckerhas been removed, the recommended replacement for Android code is Android Lint's NewApi checkNew checks:
NullNeedsCastForVarargs: Detect calls that incorrectly passes anullarray instead of anullelement.RedundantNullCheck: detect checks on expressions that are non-null.Closed issues: #4943, #5102, #5107, #5121, #5158, #5217, #5239
Full changelog: google/error-prone@v2.42.0...v2.43.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.