Skip to content

Conversation

@trask
Copy link
Member

@trask trask commented Oct 22, 2025

Fixes

Using toolchain 'Eclipse Temurin JDK 17 (17.0.16+8)' installed via auto-provisioning without toolchain repositories. This behavior has been deprecated. This will fail with an error in Gradle 10. Builds may fail when this toolchain is not available in other environments. Add toolchain repositories to this build. For more information, please refer to https://docs.gradle.org/9.1.0/userguide/toolchains.html#sub:download_repositories in the Gradle documentation.

@trask trask requested a review from a team as a code owner October 22, 2025 16:16
Comment on lines -8 to -14
if (!hasLauncherForJavaVersion(17)) {
throw GradleException(
"JDK 17 is required to build and gradle was unable to detect it on the system. " +
"Please install it and see https://docs.gradle.org/current/userguide/toolchains.html#sec:auto_detection " +
"for details on how gradle detects java toolchains."
)
}
Copy link
Member Author

@trask trask Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is needed anymore now that we have the toolchain provisioning enabled it should automatically download and use the right Java version

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.14%. Comparing base (d98302b) to head (7fe14e9).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7780      +/-   ##
============================================
- Coverage     90.16%   90.14%   -0.02%     
+ Complexity     7189     7187       -2     
============================================
  Files           814      814              
  Lines         21730    21730              
  Branches       2129     2129              
============================================
- Hits          19592    19588       -4     
- Misses         1469     1474       +5     
+ Partials        669      668       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@trask trask mentioned this pull request Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant