-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding k8 support for container id detection #1962
Open
abhee11
wants to merge
11
commits into
open-telemetry:main
Choose a base branch
from
abhee11:enhancement/adding-k8-support-for-containerId-detection
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
55b2e8d
enhancement: added k8 support and tests for container detection
abhee11 b3e4365
Merge branch 'main' into enhancement/adding-k8-support-for-containerI…
abhee11 8a4c557
reafactor: added k8 support and tests for container detection
abhee11 10e407f
refactor: added k8 support and tests for container detection
abhee11 c69f689
Merge branch 'enhancement/adding-k8-support-for-containerId-detection…
abhee11 1b95768
test: added back the new containerid test string
abhee11 acf2c55
PR review changes
abhee11 e6df278
resolving package-lock merge conflicts
abhee11 009dccb
added tests
abhee11 cd5f7b5
removed client-node deps
abhee11 5062374
removed client-node deps and upadte package-lock
abhee11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PR review changes
commit acf2c557ce9b9b29c18dacf3fdf66b3a12af30f9
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to use require instead of
import
?