fix(detector-aws): extract full container ID from ECS Fargate cgroup

[seongpil0948]

Which problem is this PR solving?

AWS ECS Fargate changed their cgroup naming convention to /ecs/<taskId>/<taskId>-<containerId> format. The existing container ID extraction logic only takes the last 64 characters, causing truncation in the middle of the taskId and resulting in incomplete container IDs like 438aa1824ca4058bdcab/c23e5f76c09d438aa1824ca4058bdcab-1234678 instead of the expected full c23e5f76c09d438aa1824ca4058bdcab-1234678.

This breaks compatibility with observability vendors like DataDog that require the complete taskId-containerId format for proper container identification.

Short description of the changes

• Enhanced container ID extraction: Extract the last path segment from cgroup paths instead of truncating to 64 characters
• New _extractContainerIdFromLine() method: Handles various container runtime formats (Docker, containerd, CRI-O) with proper prefix/suffix removal
• Flexible validation: Uses permissive regex pattern [a-zA-Z0-9\-_]+ to support real-world container ID formats
• Backward compatibility: Maintains fallback to original 64-char logic for legacy formats
• Comprehensive tests: Added test cases covering DataDog compatibility scenarios and edge cases

Supported formats:

• New ECS Fargate: /ecs/<taskId>/<taskId>-<containerId> → taskId-containerId
• Docker: /docker/containerid.scope → containerid
• Containerd: system.slice:cri-containerd:containerid → containerid
• UUID format: /uuid/34dc0b5e-626f-2c5c-4c51-70e34b10e765 → 34dc0b5e-626f-2c5c-4c51-70e34b10e765

Fixes #2455

[pichlermarc]

@seongpil0948 looks like this PR is in draft, is this intentional? 🤔

[seongpil0948]

@seongpil0948 looks like this PR is in draft, is this intentional? 🤔

i'm sorry to late .. 🫡

[david-luna]

@seongpil0948

There has been a re-organization of the packages in this repository, see #2928

Would you mind to sync your PR with main branch?

[dyladan]

Looks like this needs reviews. The conflicts are just from package naming. @jj22ee can you please take a look?

[seongpil0948]

i worked on a new branch based on new structured packages
thanks all

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.58%. Comparing base (41d272d) to head (098ef50).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2855      +/-   ##
==========================================
+ Coverage   89.55%   89.58%   +0.03%     
==========================================
  Files         193      193              
  Lines        9698     9729      +31     
  Branches     2011     2025      +14     
==========================================
+ Hits         8685     8716      +31     
  Misses       1013     1013              

Files with missing lines	Coverage Δ
...ource-detector-aws/src/detectors/AwsEcsDetector.ts	97.90% <100.00%> (+0.58%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jj22ee]

Hi @seongpil0948, wondering why not opt to use a more automated regex based approach (as mentioned in the issue, something like in DataDog/dd-trace-js#1176, which is now here)?

IMO that would help alleviate some of the burden in the current PR which adds logic to "track and remove known prefixes", execute step-by-step extraction+sanitizing of the lastSegment, and perform two sanity validations based on the length of the extracted segment based on what we think is reasonable. Regex would be more "straight to the point" at a glance, easier to maintain.

[dyladan]

@jj22ee looks like there's been changes since your last comment. I think this is ready for another review.

[jj22ee]

Ty for the fixes & enhancements! I have one remaining nit, and then I can approve.

[jj22ee]

Need help from @open-telemetry/javascript-approvers to run the remaining PR workflows.

[jj22ee]

@seongpil0948 There is a lint issue in the PR check. Should be able to be fixed by running:

cd packages/resource-detector-aws
npm run lint:fix

[Copilot]

Pull Request Overview

This PR fixes container ID extraction in AWS ECS Fargate environments by updating the logic to handle the new cgroup naming convention /ecs/<taskId>/<taskId>-<containerId>. The existing 64-character truncation was breaking compatibility with observability vendors that require the complete taskId-containerId format.

Key changes:

• Enhanced container ID extraction to prefer full path segments over character truncation
• Added new extraction methods with fallback hierarchy for different container runtime formats
• Maintained backward compatibility with legacy 64-character truncation logic

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
packages/resource-detector-aws/src/detectors/AwsEcsDetector.ts	Refactored container ID extraction logic with new methods and fallback hierarchy
packages/resource-detector-aws/test/detectors/AwsEcsDetector.test.ts	Added comprehensive test cases for various cgroup formats and edge cases

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[seongpil0948]

Thank you @pichlermarc !