-
Notifications
You must be signed in to change notification settings - Fork 598
chore(instr-undici): add ESM output #2955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
david-luna
wants to merge
6
commits into
open-telemetry:main
Choose a base branch
from
david-luna:poc-esm-output
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2955 +/- ##
=======================================
Coverage ? 97.62%
=======================================
Files ? 9
Lines ? 505
Branches ? 89
=======================================
Hits ? 493
Misses ? 12
Partials ? 0 🚀 New features to boost your workflow:
|
|
3 tasks
…js-contrib into poc-esm-output
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This is a different approach of #2954 which uses the current toolchain to generate the ESM files. Basically is another try on a similar PR targeting express which at that time did not have the best tools to work.
Short description of the changes
"type": "module"
inpackage.json
exports
property inpackage.json
tsconfig.esm.json
for ESM compilationtsconfig.json
for CJS compilation.js
extension in import statements2025-07-24 UPDATE: to simplify integration with
mocha
andts-node/esm
loader for tests I've changed the compilation steptsconfig.cjs.json
file for CJS outputts-node/esm
loader is set in the test script. IF this change is applied to all other packages we could promote this config to.mocharc.yml
Notice
This PR is meant to be reviewed along with #2954 which does the same but using a new tool for compilation. The intention is to have a conversation on the path we want to take about tooling. Should we stick to the current tools (for compilation) or change them?