feat(instrumentation-ioredis): add Redis Cluster instrumentation support #3010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Currently when using the
ioredisin cluster mode theinstrumentation-ioredispackage wraps only the standalone client methods, which cluster mode still ultimately uses, however this is a bit misleading and does not represent the correct tracing.Short description of the changes
instrumentCluster?: booleanto enable cluster instrumentationCluster.sendCommand()andCluster.connect()methodsAdditional Information
Cluster instrumentation is gated behind a configuration flag to maintain backward compatibility for users who may not need it. Additionally, the attributes for standalone clients and clusters are not fully compatible.