Skip to content

Conversation

trentm
Copy link
Contributor

@trentm trentm commented Sep 30, 2025

Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question (that you will probably will answer on a following PR once it gets solved), the rest are small nits (I get annoyed by those extra lines in the middle of the imports, but feel free to ignore if those were on purpose 😅 )

@trentm
Copy link
Contributor Author

trentm commented Oct 1, 2025

Waiting on #3130 (comment) discussion before merging this. Resolving that discussion will be a separate PR, but let's discuss first.

@trentm trentm merged commit e72c1b3 into open-telemetry:main Oct 2, 2025
18 checks passed
@trentm trentm deleted the trentm-semconv-up-metric-names-runtime-node branch October 2, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants