-
Notifications
You must be signed in to change notification settings - Fork 607
chore(instrumentation-runtime-node): update semconv usage to modern exports #3130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(instrumentation-runtime-node): update semconv usage to modern exports #3130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question (that you will probably will answer on a following PR once it gets solved), the rest are small nits (I get annoyed by those extra lines in the middle of the imports, but feel free to ignore if those were on purpose 😅 )
packages/instrumentation-runtime-node/src/metrics/eventLoopTimeCollector.ts
Show resolved
Hide resolved
packages/instrumentation-runtime-node/src/metrics/eventLoopTimeCollector.ts
Outdated
Show resolved
Hide resolved
packages/instrumentation-runtime-node/src/metrics/eventLoopTimeCollector.ts
Outdated
Show resolved
Hide resolved
packages/instrumentation-runtime-node/src/metrics/eventLoopUtilizationCollector.ts
Show resolved
Hide resolved
packages/instrumentation-runtime-node/src/metrics/eventLoopUtilizationCollector.ts
Outdated
Show resolved
Hide resolved
packages/instrumentation-runtime-node/test/event_loop_utilization.test.ts
Outdated
Show resolved
Hide resolved
packages/instrumentation-runtime-node/test/event_loop_utilization.test.ts
Outdated
Show resolved
Hide resolved
packages/instrumentation-runtime-node/test/heap_space_and_used.test.ts
Outdated
Show resolved
Hide resolved
packages/instrumentation-runtime-node/test/heap_space_and_used.test.ts
Outdated
Show resolved
Hide resolved
Per review feedback. Co-authored-by: Marylia Gutierrez <[email protected]>
Waiting on #3130 (comment) discussion before merging this. Resolving that discussion will be a separate PR, but let's discuss first. |
Refs: #2377
Refs: open-telemetry/opentelemetry-js#5956