feat(instrumentation-mongodb): add support for mongodb v7 #3283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhilash-sivan
changed the title
abhilash-sivan
force-pushed
the
feat-instrumentation-mongodb
branch
from
f172a56 to
d6dad28
Compare
Author
|
Hi @onurtemizkan, |
Member
onurtemizkan
left a comment
onurtemizkan
left a comment
There was a problem hiding this comment.
Thanks @abhilash-sivan, I added a few comments.
Looks like I can't approve the workflow run, but when I tried to run the tests locally, it's flaking.
@david-luna, can you please help us approve the CI flow?
Comment on lines
+81
to
+88
| // MongoDB v7 requires Node.js >= 20.19.0 | ||
| if (!semver.satisfies(process.version, '>=20.19.0')) { | ||
| console.log( | ||
| `Skipping mongodb v7 tests. Node.js ${process.version} does not meet minimum requirement of >=20.19.0` | ||
| ); | ||
| shouldTest = false; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Looks like this skips tests for all MongoDB versions for Node < 20
Author
There was a problem hiding this comment.
Yeah, I understand. I will update this one
Comment on lines
+19
to
+20
| "tdd": "npm run test-v7 -- --watch-extensions ts --watch", | ||
| "test": "npm run test-v7 && npm run test-unit", |
Member
There was a problem hiding this comment.
Updating our default MongoDB version / and default tests to v7 means that the contributors will need to update their Node version, right? @david-luna, are there any concerns about it?
abhilash-sivan
force-pushed
the
feat-instrumentation-mongodb
branch
from
6a7e61c to
01367e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes