chore: export shimmer functions #5865
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5865 +/- ##
=======================================
Coverage 95.03% 95.03%
=======================================
Files 306 306
Lines 7969 7969
Branches 1611 1611
=======================================
Hits 7573 7573
Misses 396 396 🚀 New features to boost your workflow:
|
david-luna
requested changes
Aug 22, 2025
| @@ -33,3 +33,4 @@ export { | |||
| safeExecuteInTheMiddleAsync, | |||
| } from './utils'; | |||
| export { SemconvStability, semconvStabilityFromStr } from './semconvStability'; | |||
| export * from './shimmer' | |||
There was a problem hiding this comment.
Please do explicit exports and make sure you mark what is a type or not. It's necessary since we enabled isolatedModules in #5697
pichlermarc
requested changes
Aug 22, 2025
There was a problem hiding this comment.
I do not have a strong opinion on exposing this to the public API.
I also don't have a strong preference. Though if we do export these, we should also deprecate the re-exports on the instrumentation base classes so that people are not left wondering which one is the "correct" one to use now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
I need to override some functionality in my code. I want to use new wrapper functions instead of relying on the old shimmer, which is incorrectly typed. I added an export so that I can use these new functions in my derived code, which is heavily based on OTel.
Fixes # (issue)
Short description of the changes
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: