Skip to content

feat: add httpsprovider #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

theSuess
Copy link
Contributor

Adds the httpsprovider to also support https:// as scheme in OPENTELEMETRY_COLLECTOR_CONFIG_URI.

@theSuess theSuess requested a review from a team as a code owner November 19, 2024 08:26
Adds the [httpsprovider](https://github.com/open-telemetry/opentelemetry-collector/tree/main/confmap/provider/httpsprovider)
to also support `https://` as scheme in `OPENTELEMETRY_COLLECTOR_CONFIG_URI`.
@theSuess theSuess force-pushed the feat/add-httpsprovider branch from da3fb17 to 020ff55 Compare November 20, 2024 07:43
@theSuess theSuess requested a review from serkan-ozal November 20, 2024 07:44
Copy link
Member

@pragmaticivan pragmaticivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (although worth keeping an eye on increase of latency on cold start)

@pragmaticivan
Copy link
Member

Also worth checking this PR https://github.com/open-telemetry/opentelemetry-lambda/pull/1277/files more changes missing? (maybe close this older pr)

@tylerbenson tylerbenson merged commit 0e0c7a0 into open-telemetry:main Dec 19, 2024
14 checks passed
@tylerbenson tylerbenson added the go Pull requests that update Go code label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants