Refactor namespace selector handling in target allocator #3790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently namespace selectors work correctly in target allocator by accident. By default, Prometheus config generation which we import from prometheus-operator only watches the Prometheus CR namespace for ServiceMonitors. We don't set that, and it just so happens that the config generation code treats that as "all namespaces". This is not the case anymore in newer versions of prometheus-operator, and so we are forced to fix this problem.
This PR explicitly sets default selectors to "all namespaces" in the target allocator config. We also set our internal Prometheus CR namespace to the collector namespace. This doesn't change anything by default, but it makes target allocator behave more similarly to Prometheus.
Link to tracking Issue(s):
Part of #3782.