Skip to content

Conversation

andrefrco
Copy link

Description:

Add TrafficDistribution field to OpenTelemetryCommonFields which is inherited by OpenTelemetryCollector and TargetAllocator. This field allows setting the traffic distribution policy for Kubernetes Services created by these resources.

Link to tracking Issue(s):

Testing:

  • Added unit tests for TrafficDistribution field in Service generation.
  • Manual tests creating OpenTelemetryCollector and TargetAllocator locally.
  • Should we create an e2e test specifically for TrafficDistribution functionality?

Documentation:

  • Added TrafficDistribution field to OpenTelemetryCollector and TargetAllocator

@andrefrco andrefrco requested a review from a team as a code owner August 25, 2025 02:19
@swiatekm
Copy link
Contributor

@andrefrco you can add this to one of the existing E2E tests, it doesn't merit its own full tests. Could you also rebase on main and run make update to remove conflicts with the generated manifests? Otherwise, your change looks good to me.

@frzifus frzifus requested a review from swiatekm September 3, 2025 21:04
Copy link
Contributor

github-actions bot commented Sep 3, 2025

E2E Test Results

 34 files  ±0  221 suites  ±0   2h 3m 48s ⏱️ - 57m 58s
 88 tests ±0   87 ✅  - 1  0 💤 ±0  1 ❌ +1 
225 runs  ±0  224 ✅  - 1  0 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit ab87977. ± Comparison against base commit c1d96e6.

♻️ This comment has been updated with latest results.

@swiatekm
Copy link
Contributor

swiatekm commented Sep 8, 2025

@andrefrco the e2e test fails on K8s 1.25, which I suspect means that TrafficDistribution isn't supported on that version. You'll need to check the K8s version in the test to account for this. This is done in a few other E2E tests, if you're not sure how to do it in chainsaw.

…TargetAllocator Services

Add TrafficDistribution field to OpenTelemetryCommonFields which is inherited by OpenTelemetryCollector and TargetAllocator. This field allows setting the traffic distribution policy for Kubernetes Services created by these resources.
@andrefrco andrefrco force-pushed the feat/traffic-distribution-support branch from 9ef1428 to ab87977 Compare September 10, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support TrafficDistribution for OpenTelemetryCollector Services
4 participants