Skip to content

Conversation

blue86321
Copy link

@blue86321 blue86321 commented Sep 9, 2025

Description:

In README ### Configure resource attributes with labels section,
claims that label app.kubernetes.io/instance will become service.instance, which is incorrect.

Label app.kubernetes.io/instance will indeed become service.name as in #3797

This logic is still valid if we go deep into the code

// pkg/constants/env.go
LabelAppName = []string{
  "app.kubernetes.io/instance",
  "app.kubernetes.io/name",
}

// internal/instrumentation/sdk.go # chooseServiceName
if name := chooseLabelOrAnnotation(pod, useLabelsForResourceAttributes, semconv.ServiceNameKey, constants.LabelAppName); name != "" {
  return name
}

#4081 misunderstood and falsely "fixed the typo". This PR is to re-fix this issue in README.md

@blue86321 blue86321 requested a review from a team as a code owner September 9, 2025 04:12
@frzifus frzifus added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 10, 2025
@frzifus frzifus enabled auto-merge (squash) September 10, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants