Remove aggregation temporality enum and field. #710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@open-telemetry/profiling-approvers |
christos68k
approved these changes
Sep 4, 2025
bogdandrutu
approved these changes
Sep 4, 2025
cijothomas
approved these changes
Sep 5, 2025
reyang
approved these changes
Sep 5, 2025
|
@aalexand could you update the changelog? Thanks! |
Sorry, how do I do that? I'm looking at past PRs in this repo and they seemingly do not update the changelog file. |
florianl
approved these changes
Sep 5, 2025
jhalliday
approved these changes
Sep 5, 2025
aalexand
force-pushed
the
rmaggtemp
branch
2 times, most recently
from
baf4956 to
1469233
Compare
|
@reyang I updated the changelog. |
The concept of aggregation temporality exists in the metrics signal and so it was copied to the profiles signal, but it's not applicable in the current form and we decided to remove it for now. Related to open-telemetry#706, fixes open-telemetry#547.
Thanks! Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The concept of aggregation temporality exists in the metrics signal and so it was copied to the profiles signal, but it's not applicable in the current form and we decided to remove it for now.
Related to #706, fixes #547.