Separate lint for httpx

open-telemetry · Apr 26, 2024 · d3f62e1 · d3f62e1
1 parent 215dc39
commit d3f62e1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/.github/workflows/lint_0.yml b/.github/workflows/lint_0.yml
@@ -67,6 +67,7 @@ jobs:
           - "instrumentation-threading"
           - "instrumentation-tornado"
           - "instrumentation-tortoiseorm"
+          - "instrumentation-httpx"
         os: [ubuntu-20.04]
     runs-on: ubuntu-20.04
     steps:

diff --git a/tox.ini b/tox.ini
@@ -295,6 +295,7 @@ envlist =
     ; 1: httpx>=0.19.0 respx~=0.20.1
     py3{8,9,10,11}-test-instrumentation-httpx-{0,1}
     pypy3-test-instrumentation-httpx-{0,1}
+    lint-instrumentation-httpx
 
     ; opentelemetry-util-http
     py3{8,9,10,11}-test-util-http
@@ -712,6 +713,7 @@ commands_pre =
   httpx: pip install opentelemetry-test-utils@{env:CORE_REPO}\#egg=opentelemetry-test-utils&subdirectory=tests/opentelemetry-test-utils
   httpx-0: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-httpx/test-requirements-0.txt
   httpx-1: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-httpx/test-requirements-1.txt
+  lint-instrumentation-httpx: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-httpx/test-requirements-1.txt
 
   sdk-extension-aws: pip install opentelemetry-api@{env:CORE_REPO}\#egg=opentelemetry-api&subdirectory=opentelemetry-api
   sdk-extension-aws: pip install opentelemetry-semantic-conventions@{env:CORE_REPO}\#egg=opentelemetry-semantic-conventions&subdirectory=opentelemetry-semantic-conventions
@@ -1059,6 +1061,12 @@ commands =
   lint-instrumentation-wsgi: pylint {toxinidir}/instrumentation/opentelemetry-instrumentation-wsgi/tests
 
   test-instrumentation-httpx: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-httpx/tests {posargs}
+  lint-instrumentation-httpx: black --diff --check --config {toxinidir}/pyproject.toml {toxinidir}/instrumentation/opentelemetry-instrumentation-httpx
+  lint-instrumentation-httpx: isort --diff --check-only --settings-path {toxinidir}/.isort.cfg {toxinidir}/instrumentation/opentelemetry-instrumentation-httpx
+  lint-instrumentation-httpx: flake8 --config {toxinidir}/.flake8 {toxinidir}/instrumentation/opentelemetry-instrumentation-httpx
+  lint-instrumentation-httpx: pylint {toxinidir}/instrumentation/opentelemetry-instrumentation-httpx/src/opentelemetry
+  lint-instrumentation-httpx: pylint {toxinidir}/instrumentation/opentelemetry-instrumentation-httpx/tests
+
   test-instrumentation-asyncio: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-asyncio/tests {posargs}
   test-util-http: pytest {toxinidir}/util/opentelemetry-util-http/tests {posargs}
 
@@ -1141,7 +1149,6 @@ commands_pre =
   pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-kafka-python/test-requirements.txt
   pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-confluent-kafka/test-requirements.txt
   pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-pika/test-requirements-1.txt
-  pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-httpx/test-requirements-1.txt
   pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-asyncio/test-requirements.txt
   # requires snappy headers to be available on the system
   pip install -r {toxinidir}/processor/opentelemetry-processor-baggage/test-requirements.txt