Skip to content

Commit

Permalink
opentelemetry-bootstrap: remove aws-lambda from default instrumentati…
Browse files Browse the repository at this point in the history
…ons (#2786)
  • Loading branch information
emdneto authored Aug 12, 2024
1 parent 6981035 commit f1f017f
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 2 deletions.
5 changes: 4 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- `opentelemetry-instrumentation-kafka-python` Instrument temporary fork, kafka-python-ng
inside kafka-python's instrumentation
([#2537](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2537)))
([#2537](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2537))

## Breaking changes

- `opentelemetry-bootstrap` Remove `opentelemetry-instrumentation-aws-lambda` from the defaults instrumentations
([#2786](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2786))

## Fixed

- `opentelemetry-instrumentation-fastapi` fix `fastapi` auto-instrumentation by removing `fastapi-slim` support, `fastapi-slim` itself is discontinued from maintainers
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,6 @@
]
default_instrumentations = [
"opentelemetry-instrumentation-asyncio==0.48b0.dev",
"opentelemetry-instrumentation-aws-lambda==0.48b0.dev",
"opentelemetry-instrumentation-dbapi==0.48b0.dev",
"opentelemetry-instrumentation-logging==0.48b0.dev",
"opentelemetry-instrumentation-sqlite3==0.48b0.dev",
Expand Down
9 changes: 9 additions & 0 deletions scripts/generate_instrumentation_bootstrap.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,21 @@
"bootstrap_gen.py",
)

# AWS Lambda instrumentation is excluded from the default list because it often
# requires specific configurations and dependencies that may not be set up
# in all environments. Instead, users who need AWS Lambda support can opt-in
# by manually adding it to their environment.
# See https://github.com/open-telemetry/opentelemetry-python-contrib/issues/2787
packages_to_exclude = ["opentelemetry-instrumentation-aws-lambda"]


def main():
# pylint: disable=no-member
default_instrumentations = ast.List(elts=[])
libraries = ast.List(elts=[])
for pkg in get_instrumentation_packages():
if pkg.get("name") in packages_to_exclude:
continue
if not pkg["instruments"]:
default_instrumentations.elts.append(ast.Str(pkg["requirement"]))
for target_pkg in pkg["instruments"]:
Expand Down

0 comments on commit f1f017f

Please sign in to comment.