Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semconv to 1.20.0 #1746

Closed
wants to merge 13 commits into from
Closed

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Apr 11, 2023

Description

Onboards instrumentations to fresh semantic conventions

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Run instrumentation tests

Does This PR Require a Core Repo Change?

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@lmolkova
Copy link
Contributor Author

lmolkova commented Jul 3, 2023

this PR is ready for the review, @opentelemetry-python-contrib-approvers please take a look!

@ocelotl
Copy link
Contributor

ocelotl commented Jul 5, 2023

Thanks, @lmolkova, I am trying to debug the failing tests in the core repo.

@lmolkova
Copy link
Contributor Author

lmolkova commented Jul 5, 2023

@ocelotl it seems core tests fail on span name check.
AssertionError: '"name": "HTTP GET"' not found in ... "name": "GET"

Span names were changed in #1759, but core tests were not updated to reflect it. I'm not sure what was the reason to remove `HTTP " from client span names, LMK what should be fixed - the name or the core tests. It seems the spec has changed - I'll update core tests. Thanks!

@ocelotl
Copy link
Contributor

ocelotl commented Jul 5, 2023

@ocelotl it seems core tests fail on span name check. AssertionError: '"name": "HTTP GET"' not found in ... "name": "GET"

Span names were changed in #1759, but core tests were not updated to reflect it. I'm not sure what was the reason to remove `HTTP " from client span names, LMK what should be fixed - the name or the core tests. Thanks!

Right, I just filed this issue, will take care of it, thanks!

@srikanthccv
Copy link
Member

I think @lzchen had some points around the transition plan. Bringing this up in the SIG meeting (again) might be a good idea.

@ocelotl
Copy link
Contributor

ocelotl commented Jul 6, 2023

I think @lzchen had some points around the transition plan. Bringing this up in the SIG meeting (again) might be a good idea.

Added to the SIG notes.

@lmolkova
Copy link
Contributor Author

lmolkova commented Oct 3, 2023

Closing this one.

Schema URL is populated in #1977, and @lzchen will prototype side-by-side new/old semconv in selected instrumentations

@lmolkova lmolkova closed this Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants