Added enable commenter #1834
Added enable commenter #1834
Conversation
|
You can run |
|
@shalevr Could you please have a look and let me know. |
...tion/opentelemetry-instrumentation-mysql/src/opentelemetry/instrumentation/mysql/__init__.py
Outdated
Show resolved
Hide resolved
…lemetry/instrumentation/mysql/__init__.py Co-authored-by: Shalev Roda <[email protected]>
instrumentation/opentelemetry-instrumentation-mysql/tests/test_mysql_integration.py
Show resolved
Hide resolved
|
|
||
| @mock.patch("mysql.connector.connect") | ||
| # pylint: disable=unused-argument | ||
| def test_sqlcommenter_disabled(self, event_mocked): |
There was a problem hiding this comment.
@rahuldimri these tests are failing, please take a look. This PR has enough approvals, we only need these tests to pass in order to merge it.
There was a problem hiding this comment.
Sure let me work on this.
There was a problem hiding this comment.
@rahuldimri I fixed the failing docs tests, we only need this test case to pass and we can merge this PR ✌️
There was a problem hiding this comment.
@ocelotl let me have a look !!
There was a problem hiding this comment.
Are you still working on this? Still seems like there are test cases that are failing.
There was a problem hiding this comment.
Hi @rahuldimri , are you still working on this PR?
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #1387
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.