Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unwrap Celery's ExceptionInfo #1863

Merged
merged 5 commits into from
Sep 3, 2023
Merged

Unwrap Celery's ExceptionInfo #1863

merged 5 commits into from
Sep 3, 2023

Commits on Sep 1, 2023

  1. Unwrap ExceptionInfo and ExceptionWithTraceback 

    Instead of reporting the `ExceptionInfo` and `ExceptionWithTraceback`
wrappers raised by Celery, report the exceptions that they wrap.

This ensures that the exception in the OpenTelemetry span has a type
and traceback that are meaningful and relevant to the developer.
    @unflxw
    unflxw committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    fdf8a65 View commit details
    Browse the repository at this point in the history

  2. Fix typo 

    The exception is expected, not excepted. Well, I guess it is also
excepted, because it's an exception, but you get what I mean.
    @unflxw
    unflxw committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    08bd6e0 View commit details
    Browse the repository at this point in the history

  3. Reformat file with black 

    Reformat the `__init__.py` file in the Celery instrumentation using
`black`, fixing a CI linter error.
    @unflxw
    unflxw committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    0293c4e View commit details
    Browse the repository at this point in the history

  4. Address review feedback 

    Use the VERSION attribute exposed by Billiard to decide whether to
import ExceptionWithTraceback.

Add a test for a failing task and check that the exceptions' type
and message are preserved.
    @unflxw
    unflxw committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    d09933a View commit details
    Browse the repository at this point in the history

  5. Amend ExceptionWithTraceback import

    @unflxw
    unflxw committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    fb909ed View commit details
    Browse the repository at this point in the history