Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PoC for adding lambda function trigger identifier #1906

Closed

Conversation

shuwpan
Copy link

@shuwpan shuwpan commented Aug 9, 2023

Description

PoC for adding 'faas.trigger_id' span attribute for elb, sns, sqs, s3.
Proof of concept for (open-telemetry/semantic-conventions#262)
Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Unit test
  • Deployed code as lambda layer on aws to verify "faas.trigger_id" is set properly for s3, sns, sqs, alb

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@shuwpan shuwpan marked this pull request as draft August 9, 2023 21:10
@shuwpan shuwpan closed this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant