Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare asgi tests to support newer asgiref version #2778

Merged
merged 5 commits into from
Aug 26, 2024

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Aug 5, 2024

Description

This is trying to update the asgi tests, but this is draft because I'm not able to understand what's missing for middleware tests. It should be something trivial when interacting with the middleware because even basic tests are failing :)
Requires open-telemetry/opentelemetry-python#4106

Fixes #2776

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Core Repo Change?

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xrmx xrmx changed the title Fix asgi test swith newer asgiref Fix asgi tests with newer asgiref Aug 5, 2024
@drupol
Copy link

drupol commented Aug 5, 2024

With the patches you made, we are now at:

 ================== 28 failed, 52 passed, 3 warnings in 2.26s ===================

Things are progressing in the right direction :)

@xrmx
Copy link
Contributor Author

xrmx commented Aug 6, 2024

I won't be able to work on this for the next couple of weeks so please feel free to take over.

@drupol
Copy link

drupol commented Aug 6, 2024

It's totally fine. I have no knowledge in this project and these technologies yet. In the meantime, we've disabled the tests in Nix (NixOS/nixpkgs@b7ac9d1), so this thing can wait, no worries.

@xrmx xrmx force-pushed the fix-asgi-test-with-newer-asgiref branch from 844e1a4 to 5ee216a Compare August 19, 2024 09:02
@emdneto
Copy link
Member

emdneto commented Aug 23, 2024

In the meantime, I'm making some progress in #2818. But a test is failing for Pypy, and I am still trying to figure out why. @drupol could you please test against #2818 while we fix the pypy failing test?

@emdneto emdneto added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 23, 2024
@emdneto emdneto changed the title Fix asgi tests with newer asgiref Prepare asgi tests to support newer asgiref version Aug 23, 2024
tox.ini Outdated Show resolved Hide resolved
@xrmx xrmx force-pushed the fix-asgi-test-with-newer-asgiref branch from bddb238 to 357067a Compare August 26, 2024 14:27
@xrmx xrmx marked this pull request as ready for review August 26, 2024 14:27
@lzchen lzchen merged commit 19f8e77 into open-telemetry:main Aug 26, 2024
521 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

asgiref 3.8 compatibility?
4 participants