Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2677 jinja2 semconv #2798

Conversation

the-chandru
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #2677

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox -e test-instrumentation-jinja2

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@the-chandru
Copy link
Contributor Author

Hi @ocelotl,

I have made the update to changelog, will be pushing it soon.

@lzchen
Copy link
Contributor

lzchen commented Aug 14, 2024

@the-chandru

Since there are no stable semantic conventions for templating we probably won't start this work. @emdneto @ocelotl @xrmx Not sure if there will ever be stable sem convs from templating libraries, should we remove this from the list of migrations?

@emdneto
Copy link
Member

emdneto commented Aug 14, 2024

@the-chandru

Since there are no stable semantic conventions for templating we probably won't start this work. @emdneto @ocelotl @xrmx Not sure if there will ever be stable sem convs from templating libraries, should we remove this from the list of migrations?

I'm okay with that. I failed to find a relationship with any set of attributes we currently have in the recent version of semconv. The closest attributes I found were file attributes (https://opentelemetry.io/docs/specs/semconv/attributes-registry/file/). Since we have another migration work in progress here, I think it's okay to drop this without affecting the number of instrumentations we agreed to migrate.

@lzchen
Copy link
Contributor

lzchen commented Aug 15, 2024

Discussed during the 08/15/2024 Python SIG.

We will be removing jinja from the list of required instrumentations to carry the migration plan since there does not seem to be semantic conventions defined for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opentelemetry-instrumentation-jinja2: semantic convention stability migration
4 participants