-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ability to optionally disable internal HTTP send and receive spans #2802
feat: add ability to optionally disable internal HTTP send and receive spans #2802
Conversation
|
...lemetry-instrumentation-asgi/src/opentelemetry/instrumentation/asgi/environment_variables.py
Outdated
Show resolved
Hide resolved
...tation/opentelemetry-instrumentation-asgi/src/opentelemetry/instrumentation/asgi/__init__.py
Outdated
Show resolved
Hide resolved
...tation/opentelemetry-instrumentation-asgi/src/opentelemetry/instrumentation/asgi/__init__.py
Outdated
Show resolved
Hide resolved
...tation/opentelemetry-instrumentation-asgi/src/opentelemetry/instrumentation/asgi/__init__.py
Outdated
Show resolved
Hide resolved
.../opentelemetry-instrumentation-fastapi/src/opentelemetry/instrumentation/fastapi/__init__.py
Show resolved
Hide resolved
...tation/opentelemetry-instrumentation-asgi/src/opentelemetry/instrumentation/asgi/__init__.py
Outdated
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next time please better shut up pylint warnings on methods size and do the separation in helpers separately to ease review
instrumentation/opentelemetry-instrumentation-asgi/tests/test_asgi_middleware.py
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-asgi/tests/test_asgi_middleware.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Riccardo Magliocchetti <[email protected]>
Changes look good to us! I think you have a few tests that are failing as a result of your changes. |
Ugh! I ran it with assert locally and it worked, didn't check the self.assertTrue suggestion. I'm away from home on leave now so I'll see if I can fix whatever broke from another pc 🤔 |
Description
This PR addresses the issue where it is not possible to disable internal HTTP send and receive spans. For many members of the community these do not provide any value and only add noise to the traces. Other mechanisms of filtering them out, such as wrapping span processors or exporters are clunky.
Providing arguments that allow users to disable one or both of these would be of great benefit.
Fixes #831 and addresses user comments in the now closed PR #815
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.