fix ut in pypy

[gongbenhua]

Description

fix ut for pypy

Fixes #2410

Type of change

Please delete options that are not relevant.

• [√] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

UT ofpypy can pass after changing

Does This PR Require a Core Repo Change?

• No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

• Followed the style guidelines of this project
• Changelogs have been updated
• Unit tests have been added
• Documentation has been updated

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: gongbenhua / name: Jack Gong (48524f1, 237a9a4, a2da45b, 1806094, cdb621a, fbaa4c9, 0ea3864, 8aa38d0)

[lzchen]

@xrmx

Is the original issue even valid anymore? I have not seen fastapi flaky tests for awhile.

[xrmx]

@xrmx

Is the original issue even valid anymore? I have not seen fastapi flaky tests for awhile.

Yeah, the delta has been already bumped n da78275.

Closing.

[gongbenhua]

Hi, @lzchen @xrmx @emdneto
Thanks for your reply. But I think you may I think there might be a misunderstanding.
This PR is intended to to address issue 2410 :#2410
As far as I understand, this issue is to make test with pypy all passed. But the main branch is still can't pass the test with pypy
You can try with "tox -e pypy3-test-opentelemetry-instrumentation-fastapi"
I just test it locally, there still have 9 test failed(This is exactly the issue my PR aims to address.)
Since the test with pypy still can't pass, I think my PR is needed. Can you have a test and reopen it?

[gongbenhua]

Hi, @lzchen @xrmx @emdneto Thanks for your reply. But I think you may I think there might be a misunderstanding. This PR is intended to to address issue 2410 :#2410 As far as I understand, this issue is to make test with pypy all passed. But the main branch is still can't pass the test with pypy You can try with "tox -e pypy3-test-opentelemetry-instrumentation-fastapi" I just test it locally, there still have 9 test failed(This is exactly the issue my PR aims to address.) Since the test with pypy still can't pass, I think my PR is needed. Can you have a test and reopen it?

If you think the issue 2410 :#2410 has been fixed according to your request, Can I create a new issue to fix the error that "pypy3-test-opentelemetry-instrumentation-fastapi" can't all pass and create a new PR to implement it ? Thanks a lot.

[xrmx]

@gongbenhua tests are working fine here locally and we haven't seen any failure in the CI. The code that was failing has been already updated to take a bigger delta. What failures do you have?

[gongbenhua]

@xrmx Here is the failures I got. There're total 9 failures for "tox -e pypy3-test-opentelemetry-instrumentation-fastapi". Due to length limitations, I only pasted two places

_______________________________________________ TestFastAPIManualInstrumentation.test_basic_post_request_metric_success_both_semconv ________________________________________________

self = <tests.test_fastapi_instrumentation.TestFastAPIManualInstrumentation testMethod=test_basic_post_request_metric_success_both_semconv>

    def test_basic_post_request_metric_success_both_semconv(self):
        start = default_timer()
        response = self._client.post(
            "/foobar",
            json={"foo": "bar"},
        )
        duration = max(round((default_timer() - start) * 1000), 0)
        duration_s = max(default_timer() - start, 0)
        response_size = int(response.headers.get("content-length"))
        request_size = int(response.request.headers.get("content-length"))
        metrics_list = self.memory_metrics_reader.get_metrics_data()
        for metric in (
            metrics_list.resource_metrics[0].scope_metrics[0].metrics
        ):
            for point in list(metric.data.data_points):
                if isinstance(point, HistogramDataPoint):
                    self.assertEqual(point.count, 1)
                    if metric.name == "http.server.request.duration":
                        self.assertAlmostEqual(duration_s, point.sum, places=1)
                    elif metric.name == "http.server.response.body.size":
                        self.assertEqual(response_size, point.sum)
                    elif metric.name == "http.server.request.body.size":
                        self.assertEqual(request_size, point.sum)
                    elif metric.name == "http.server.duration":
>                       self.assertAlmostEqual(duration, point.sum, delta=40)
E                       AssertionError: 223 != 18 within 40 delta (205 difference)

instrumentation\opentelemetry-instrumentation-fastapi\tests\test_fastapi_instrumentation.py:896: AssertionError
________________________________________________ TestFastAPIManualInstrumentation.test_basic_post_request_metric_success_new_semconv ________________________________________________

self = <tests.test_fastapi_instrumentation.TestFastAPIManualInstrumentation testMethod=test_basic_post_request_metric_success_new_semconv>

    def test_basic_post_request_metric_success_new_semconv(self):
        start = default_timer()
        response = self._client.post(
            "/foobar",
            json={"foo": "bar"},
        )
        duration_s = max(default_timer() - start, 0)
        response_size = int(response.headers.get("content-length"))
        request_size = int(response.request.headers.get("content-length"))
        metrics_list = self.memory_metrics_reader.get_metrics_data()
        for metric in (
            metrics_list.resource_metrics[0].scope_metrics[0].metrics
        ):
            for point in list(metric.data.data_points):
                if isinstance(point, HistogramDataPoint):
                    self.assertEqual(point.count, 1)
                    if metric.name == "http.server.request.duration":
>                       self.assertAlmostEqual(duration_s, point.sum, places=1)
E                       AssertionError: 0.1789492000000017 != 0.006499199999998595 within 1 places (0.1724500000000031 difference)

instrumentation\opentelemetry-instrumentation-fastapi\tests\test_fastapi_instrumentation.py:864: AssertionError
================================================================ 9 failed, 46 passed, 2 skipped, 59 warnings in 28.23s ===============================================================

[xrmx]

Ah you are on windows. I've reopened the issue then.

[gongbenhua]

Ah you are on windows. I've reopened the issue then.

Thanks a lot. Can you reopen this PR so I can push my new changed code here?

[lzchen]

@gongbenhua

Please rebase with main and enable maintainer edits so we can rebase for you in the future.

[gongbenhua]

@gongbenhua

Please rebase with main and enable maintainer edits so we can rebase for you in the future.

Thanks for your reply. I have rebase with main and push my branch. You can take a look when you're free. Thanks.

[gongbenhua]

@lzchen @emdneto Hi, Sorry to bother you. Can you help me to add a skip changelog label for my PR. Thanks.
I can't enable maintainer edits from myside for some reason I don't know. But I have rebased with main