Fix instrumentation of SQLAlchemy when using sqlalchemy.engine_from_config #2816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqlalchemy.engine_from_config directly calls create_engine imported from that path; if we don't wrap that copy of the `create_engine` call then engines created via engine_from_config are not instrumented.
emdneto
reviewed
Aug 23, 2024
xrmx
approved these changes
Aug 23, 2024
Co-authored-by: Emídio Neto <[email protected]>
emdneto
approved these changes
Aug 23, 2024
emdneto
requested changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where SQLAlchemy engines created via
sqlalchemy.engine_from_config(...)are not instrumented bySQLAlchemyInstrumentor.sqlalchemy.engine_from_config(...)directly callscreate_engine(...)imported fromsqlalchemy.engine.create. If we don't wrap that copy of thecreate_enginemethod then engines created viaengine_from_configare notinstrumented.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.