Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: don't strip \n for last item on listing #2820

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Aug 25, 2024

Description

When printing available instrumentation libraries don't strip the new line from the last item.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox -e py311-test-opentelemetry-instrumentation

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

When printing available instrumentation libraries don't strip the new
line from the latest item.
@xrmx xrmx requested a review from a team August 25, 2024 09:19
@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 25, 2024
@lzchen lzchen merged commit 476f6e2 into open-telemetry:main Aug 26, 2024
521 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants