Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.rst #2849

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Update README.rst #2849

merged 1 commit into from
Sep 4, 2024

Conversation

blueswen
Copy link
Contributor

@blueswen blueswen commented Sep 4, 2024

The URL link is incorrect; it should be a repository in the open-telemetry account.

Description

The URL link https://github.com/flands/opentelemetry-python-contrib/blob/main/opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap_gen.py should be https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap_gen.py.

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

How Has This Been Tested?

It’s only a documentation update, so there is no need to test.

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

The URL link is incorrect; it should be a repository in the open-telemetry account.
@blueswen blueswen requested a review from a team September 4, 2024 10:11
Copy link
Contributor

@zhihali zhihali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this should be updated. I've compared the two versions, and the opentelemetry one is more up to date. Here are some key differences for the approvers:

Instrumentation Versions: opentelemetry uses 0.49b0.dev, while the personal repo uses 0.44b0.dev.
Library Versions:
confluent-kafka: opentelemetry supports up to 2.4.0, personal repo up to 2.2.0.
elasticsearch: opentelemetry starts at 6.0, personal repo from 2.0.
Additional Libraries: opentelemetry includes kafka-python-ng, which isn't in the personal repo.

@emdneto emdneto added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 4, 2024
@xrmx
Copy link
Contributor

xrmx commented Sep 4, 2024

Good catch!

@xrmx xrmx merged commit d6e667f into open-telemetry:main Sep 4, 2024
521 of 522 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants