Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING: add a note about instrumentation versioning and depdendencies #2851

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Sep 4, 2024

Description

Add a bit more context about versioning of instrumentation libraries after discussion with an implementor.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xrmx xrmx requested a review from a team September 4, 2024 13:20
@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 4, 2024
CONTRIBUTING.md Outdated Show resolved Hide resolved
@lzchen lzchen merged commit 9cced97 into main Sep 4, 2024
1039 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants