Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource detector for host properties #2856

Closed

Conversation

oliver-zhang
Copy link

Description

This PR will create a resource module in contrib repo which will fetch the host.name,host.arch properties

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A:By providing unit test cases

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@oliver-zhang oliver-zhang requested a review from a team September 5, 2024 10:16
@xrmx
Copy link
Contributor

xrmx commented Sep 5, 2024

Thanks for the PR, we currently keep non cloud resource detectors in the main repo inside the sdk itself, see https://github.com/open-telemetry/opentelemetry-python/tree/main/opentelemetry-sdk/src/opentelemetry/sdk/resources

The plan is to merge all the resource attributes on the otel resource detector when they are marked stable.

@pmcollins
Copy link
Member

Thanks for the PR @oliver-zhang. There is a need from my organization for a host resource detector, so this is a welcome change from my perspective. But as Riccardo suggests, this can probably live with the other non-cloud resource detectors, such as the ProcessResourceDetector in the core repo.

How do you feel about perhaps opening a PR there instead?

@oliver-zhang
Copy link
Author

Thanks for the PR @oliver-zhang. There is a need from my organization for a host resource detector, so this is a welcome change from my perspective. But as Riccardo suggests, this can probably live with the other non-cloud resource detectors, such as the ProcessResourceDetector in the core repo.

How do you feel about perhaps opening a PR there instead?

Ok, I will close this pr

@oliver-zhang oliver-zhang deleted the resource-detector-host branch September 7, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants