Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pkg resources #2871

Merged
merged 38 commits into from
Oct 19, 2024
Merged

Remove pkg resources #2871

merged 38 commits into from
Oct 19, 2024

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Sep 13, 2024

Description

This incorporates all previous work from @Rodrigo-Novas and @ocelotl and makes ci happy.

Fixes #2180
Fixes #1970
Fixes #2843

Closes #1973 #2124 #2181 #2854

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xrmx xrmx marked this pull request as ready for review October 17, 2024 08:55
@xrmx xrmx requested a review from a team as a code owner October 17, 2024 08:55
@xrmx xrmx changed the title WIP Remove pkg resources Remove pkg resources Oct 17, 2024
@mlavin
Copy link

mlavin commented Oct 17, 2024

Tested out locally and it works for me. My benchmarks show a ~100-200ms improvement in the import/start time when manually configuring and ~400-500ms when using the auto-instrumentation. Thank you to everyone who contributed towards this change and I can't wait to see this land 🙌

Co-authored-by: Emídio Neto <[email protected]>
@lzchen lzchen merged commit e4ece57 into open-telemetry:main Oct 19, 2024
528 checks passed
@moserke
Copy link

moserke commented Nov 4, 2024

Do we know when this will make it into a release? Looks like there has not been a release since August, will one be coming soon? I see this in the CHANGELOG.md. It's blocking us from being able to go to python 3.12, so mostly just curious on timing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet